wirybeaver commented on code in PR #15203:
URL: https://github.com/apache/pinot/pull/15203#discussion_r2083225163
##########
pinot-common/src/main/java/org/apache/pinot/common/metrics/BrokerMeter.java:
##########
@@ -50,6 +50,18 @@ public class BrokerMeter implements AbstractMetrics.Meter {
* That means it can be used to know how many single-stage queries have been
started in total.
*/
public static final BrokerMeter QUERIES_GLOBAL = create("QUERIES_GLOBAL",
"queries", true);
+ /**
+ * Number of queries executed, this metric is not global and is attached to
a particular replica group.
+ * <p>
+ * At this moment, this counter include single stage queries only.
+ */
+ public static final BrokerMeter REPLICA_QUERIES = create("REPLICA_QUERIES",
"routing", false);
+ /**
+ * Number of segment queries executed, this metric is not global and is
attached to a particular replica group.
+ * <p>
+ * At this moment, this counter include single stage queries only.
+ */
+ public static final BrokerMeter REPLICA_SEG_QUERIES =
create("REPLICA_SEG_QUERIES", "routing", false);
Review Comment:
need an approach to show the blast radius during rollout. The other metric
shows the traffic are equal among replicas when we do the isolation group based
version upgrade. This metrics aims to count the number of segments hit per
replica, we will see most of segments are limited to preferred replica group.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
