praveenc7 commented on code in PR #15585:
URL: https://github.com/apache/pinot/pull/15585#discussion_r2050943100
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java:
##########
@@ -985,6 +1010,11 @@ protected File
downloadSegmentFromDeepStore(SegmentZKMetadata zkMetadata)
segmentTarFile, segmentTarFile.length());
untarredSegmentDir = untarSegment(segmentName, segmentTarFile,
tempRootDir);
}
+ long downloadDurationMs = System.currentTimeMillis() -
downloadStartTimeMs;
Review Comment:
This might also include some untarring/decrpt time as well. If we need more
fine grained we can go one level below and add the duration without this
operation of untarring/decrpt
##########
pinot-common/src/main/java/org/apache/pinot/common/metrics/ServerTimer.java:
##########
@@ -43,8 +43,13 @@ public enum ServerTimer implements AbstractMetrics.Timer {
RESPONSE_SER_CPU_TIME_NS("nanoseconds", false, "Query cost (response
serialization cpu time) "
+ "for query processing on server. Computed as the time spent in
serializing query response on servers"),
-
- SEGMENT_UPLOAD_TIME_MS("milliseconds", false),
+ // Measures only the time taken to upload the segment to the deep store,
doesn't include server processing time
+ SEGMENT_UPLOAD_TIME_MS("milliseconds", true),
Review Comment:
Didn't add a Total for Upload, since the pre-processing currently didn't
seem significant. We can add one if we need it for completeness as download
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
