Jackie-Jiang commented on code in PR #15528: URL: https://github.com/apache/pinot/pull/15528#discussion_r2047644741
########## pinot-spi/src/main/java/org/apache/pinot/spi/config/table/UpsertConfig.java: ########## @@ -44,12 +46,16 @@ public enum ConsistencyMode { } @JsonPropertyDescription("Upsert mode.") - private Mode _mode; + private Mode _mode = Mode.FULL; Review Comment: Yes. We don't allow `mode` to be `null`, so this one just simplifies the setup for test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org