Jackie-Jiang commented on code in PR #15528: URL: https://github.com/apache/pinot/pull/15528#discussion_r2045687127
########## pinot-spi/src/main/java/org/apache/pinot/spi/config/table/UpsertConfig.java: ########## @@ -19,15 +19,17 @@ package org.apache.pinot.spi.config.table; import com.fasterxml.jackson.annotation.JsonPropertyDescription; -import java.util.Collections; +import com.google.common.base.Preconditions; import java.util.List; import java.util.Map; import javax.annotation.Nullable; import org.apache.commons.collections4.CollectionUtils; +import org.apache.commons.lang3.StringUtils; import org.apache.pinot.spi.config.BaseJsonConfig; +import org.apache.pinot.spi.utils.Enablement; -/** Class representing upsert configuration of a table. */ +/// Class representing upsert configuration of a table. Review Comment: This is the new javadoc format (3 '/' instead of 2) which is more concise ########## pinot-spi/src/main/java/org/apache/pinot/spi/config/table/UpsertConfig.java: ########## @@ -19,15 +19,17 @@ package org.apache.pinot.spi.config.table; import com.fasterxml.jackson.annotation.JsonPropertyDescription; -import java.util.Collections; +import com.google.common.base.Preconditions; import java.util.List; import java.util.Map; import javax.annotation.Nullable; import org.apache.commons.collections4.CollectionUtils; +import org.apache.commons.lang3.StringUtils; import org.apache.pinot.spi.config.BaseJsonConfig; +import org.apache.pinot.spi.utils.Enablement; -/** Class representing upsert configuration of a table. */ +/// Class representing upsert configuration of a table. Review Comment: This is the new javadoc format (3 `/` instead of 2) which is more concise -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
