Jackie-Jiang commented on code in PR #15528:
URL: https://github.com/apache/pinot/pull/15528#discussion_r2045682172
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/TableConfigUtils.java:
##########
@@ -744,17 +744,18 @@ static void validateUpsertAndDedupConfig(TableConfig
tableConfig, Schema schema)
Preconditions.checkState(upsertConfig.getMetadataTTL() == 0,
"enableDeletedKeysCompactionConsistency and metadataTTL shouldn't
exist together for upsert table");
- // enableDeletedKeysCompactionConsistency shouldn't exist with
enablePreload
- Preconditions.checkState(!upsertConfig.isEnablePreload(),
- "enableDeletedKeysCompactionConsistency and enablePreload
shouldn't exist together for upsert table");
+ // enableDeletedKeysCompactionConsistency shouldn't exist with preload
enabled
+ Preconditions.checkState(upsertConfig.getPreload() !=
Enablement.ENABLE,
Review Comment:
It cannot be `ENABLE`, but can be `DEFAULT` or `DISABLE`. After server
override, we need it to be disabled
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
