Jackie-Jiang commented on code in PR #15436: URL: https://github.com/apache/pinot/pull/15436#discussion_r2036270631
########## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalanceLogger.java: ########## @@ -0,0 +1,61 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.controller.helix.core.rebalance; + +import org.slf4j.Logger; +import org.slf4j.helpers.MessageFormatter; + + +public class TableRebalanceLogger { + private final Logger _logger; + private final String _rebalanceJobId; + + public TableRebalanceLogger(Logger baseLogger) { + _logger = baseLogger; + _rebalanceJobId = ""; + } + + public TableRebalanceLogger(Logger baseLogger, String rebalanceJobId) { Review Comment: (nit) It is not really used as base logger ```suggestion public TableRebalanceLogger(Logger logger, String rebalanceJobId) { ``` ########## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalanceLogger.java: ########## @@ -0,0 +1,61 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.controller.helix.core.rebalance; + +import org.slf4j.Logger; +import org.slf4j.helpers.MessageFormatter; + + +public class TableRebalanceLogger { + private final Logger _logger; + private final String _rebalanceJobId; + + public TableRebalanceLogger(Logger baseLogger) { Review Comment: Do we every initiate this logger without an id? The log will be very strange without job id. ########## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalanceLogger.java: ########## @@ -0,0 +1,61 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.controller.helix.core.rebalance; + +import org.slf4j.Logger; +import org.slf4j.helpers.MessageFormatter; + + +public class TableRebalanceLogger { + private final Logger _logger; + private final String _rebalanceJobId; + + public TableRebalanceLogger(Logger baseLogger) { + _logger = baseLogger; + _rebalanceJobId = ""; + } + + public TableRebalanceLogger(Logger baseLogger, String rebalanceJobId) { + _logger = baseLogger; + _rebalanceJobId = rebalanceJobId; + } + + private static String formatMessage(String message, String rebalanceJobId, Object... args) { + if (args.length == 0) { + return "[" + rebalanceJobId + "] " + message; + } + return "[" + rebalanceJobId + "] " + MessageFormatter.arrayFormat(message, args).getMessage(); Review Comment: We don't want to pre-format the message because it can add overhead when the log level is high (especially for debug info which is almost always skipped). Actually always passing `Object... args` is already adding unnecessary overhead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
