klsince commented on code in PR #15338:
URL: https://github.com/apache/pinot/pull/15338#discussion_r2006511133
##########
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/ControllerPeriodicTasksIntegrationTest.java:
##########
@@ -233,29 +236,34 @@ public void testSegmentStatusChecker()
numTables)) {
return false;
}
- if
(!checkSegmentStatusCheckerMetrics(TableNameBuilder.OFFLINE.tableNameWithType(emptyTable),
null, NUM_REPLICAS,
+ if
(!checkSegmentStatusCheckerMetrics(TableNameBuilder.OFFLINE.tableNameWithType(emptyTable),
null, null,
+ NUM_REPLICAS,
Review Comment:
format those lines a bit
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/SegmentStatusChecker.java:
##########
@@ -272,6 +272,12 @@ private void updateSegmentMetrics(String
tableNameWithType, TableConfig tableCon
}
ExternalView externalView =
_pinotHelixResourceManager.getTableExternalView(tableNameWithType);
Review Comment:
perhaps move this stmt and your new changes down to L347 where externalView
is used for the first time.
```
ExternalView externalView =
_pinotHelixResourceManager.getTableExternalView(tableNameWithType);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
