rhodo commented on code in PR #15338:
URL: https://github.com/apache/pinot/pull/15338#discussion_r2006521667
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/SegmentStatusChecker.java:
##########
@@ -272,6 +272,12 @@ private void updateSegmentMetrics(String
tableNameWithType, TableConfig tableCon
}
ExternalView externalView =
_pinotHelixResourceManager.getTableExternalView(tableNameWithType);
Review Comment:
I was thinking about the same thing but realized that existing logic is
nested in the segment iteration loop
[here](https://github.com/apache/pinot/blob/master/pinot-controller/src/main/java/org/apache/pinot/controller/helix/SegmentStatusChecker.java#L294),
whereas the new metrics here should be per table so I just put it here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
