somandal commented on code in PR #15368:
URL: https://github.com/apache/pinot/pull/15368#discussion_r2021915232
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java:
##########
@@ -120,16 +130,22 @@
*/
public class TableRebalancer {
private static final Logger LOGGER =
LoggerFactory.getLogger(TableRebalancer.class);
+ private static final int TOP_N_IN_CONSUMING_SEGMENT_SUMMARY = 10;
private final HelixManager _helixManager;
private final HelixDataAccessor _helixDataAccessor;
private final TableRebalanceObserver _tableRebalanceObserver;
private final ControllerMetrics _controllerMetrics;
private final RebalancePreChecker _rebalancePreChecker;
private final TableSizeReader _tableSizeReader;
+ private final ExecutorService _executorService;
+ private final HttpClientConnectionManager _connectionManager;
+ private final PinotHelixResourceManager _pinotHelixResourceManager;
public TableRebalancer(HelixManager helixManager, @Nullable
TableRebalanceObserver tableRebalanceObserver,
@Nullable ControllerMetrics controllerMetrics, @Nullable
RebalancePreChecker rebalancePreChecker,
- @Nullable TableSizeReader tableSizeReader) {
+ @Nullable TableSizeReader tableSizeReader, @Nullable ExecutorService
executorService,
Review Comment:
sure sounds good. let's open a ticket or add an item to the sheet to track
this improvement
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
