somandal commented on code in PR #15368:
URL: https://github.com/apache/pinot/pull/15368#discussion_r2019841819
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/RebalanceSummaryResult.java:
##########
@@ -380,6 +464,11 @@ public RebalanceChangeInfo getNumSegmentsInSingleReplica()
{
public RebalanceChangeInfo getNumSegmentsAcrossAllReplicas() {
return _numSegmentsAcrossAllReplicas;
}
+
+ @JsonProperty
+ public ConsumingSegmentToBeMovedSummary
getConsumingSegmentToBeMovedSummary() {
Review Comment:
also AFAIK it works correctly for `RebalanceResult`:
```
@JsonInclude(JsonInclude.Include.NON_NULL)
private final Map<String, InstancePartitions> _tierInstanceAssignment;
```
I never see this show up as null in the result
Can you double check if something else is going on due to which you've had
to add this to the getter instead of the field?
edit: i realized that `RebalanceResult` has the annotation at the class
level, so maybe that's why it works as expected. If the field level is not
working, let's just add the annotation at the class level for all the objects
in the summary class. remove from getter and field (and validate that this
works as expected please)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
