J-HowHuang commented on code in PR #15284:
URL: https://github.com/apache/pinot/pull/15284#discussion_r2019090910
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java:
##########
@@ -662,6 +663,29 @@ private RebalanceSummaryResult
calculateDryRunSummary(Map<String, Map<String, St
Set<String> serversRemoved = new HashSet<>();
Set<String> serversUnchanged = new HashSet<>();
Set<String> serversGettingNewSegments = new HashSet<>();
+ Map<String, RebalanceSummaryResult.TagInfo> tagsInfoMap = new HashMap<>();
+ String serverTenantName = tableConfig.getTenantConfig().getServer();
+ if (serverTenantName != null) {
+ String serverTenantTag =
+ TagNameUtils.getServerTagForTenant(serverTenantName,
tableConfig.getTableType());
+ tagsInfoMap.put(serverTenantTag,
+ new RebalanceSummaryResult.TagInfo(serverTenantTag));
+ }
+ if (tableConfig.getInstanceAssignmentConfigMap() != null) {
+ // for simplicity, including all segment types present in
instanceAssignmentConfigMap
+
tableConfig.getInstanceAssignmentConfigMap().values().forEach(instanceAssignmentConfig
-> {
+ if (instanceAssignmentConfig.getTagPoolConfig().isPoolBased()) {
Review Comment:
If `poolBase` is set to false, would the pool tag still be used to assign
instance? If so, do you want to include that just for showing the information
of the tag having 0 segment added and 0 server participating with it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
