somandal commented on code in PR #15284:
URL: https://github.com/apache/pinot/pull/15284#discussion_r2019072233


##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java:
##########
@@ -662,6 +663,20 @@ private RebalanceSummaryResult 
calculateDryRunSummary(Map<String, Map<String, St
     Set<String> serversRemoved = new HashSet<>();
     Set<String> serversUnchanged = new HashSet<>();
     Set<String> serversGettingNewSegments = new HashSet<>();
+    Map<String, RebalanceSummaryResult.TenantInfo> tenantInfoMap = new 
HashMap<>();
+    String serverTenantName = tableConfig.getTenantConfig().getServer();

Review Comment:
   @Jackie-Jiang is it okay to include both the tenant tag from config and the 
pool tag? or do you think we should handle the precedence?
   
   IMO if we have a clear precedence we should only include the tag based on 
that to avoid confusion? thoughts?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to