somandal commented on code in PR #15330:
URL: https://github.com/apache/pinot/pull/15330#discussion_r2007876312
##########
docker/images/pinot/etc/jmx_prometheus_javaagent/configs/controller.yml:
##########
@@ -48,6 +48,21 @@ rules:
table: "$2$4"
tableType: "$5"
taskType: "$6"
+ # Special handling for timers like cronSchedulerJobExecutionTimeMs and
tableRebalanceExecutionTimeMs
Review Comment:
actually `operationStatus` may not make much sense either since for the
`cronSchedulerJobExecutionTimeMs` the argument is actually supposed to be the
task name, e.g. `taskType="SegmentImportTask"`
```
pinotTaskManager.getControllerMetrics().addTimedTableValue(PinotTaskManager.getCronJobName(table,
taskType),
ControllerTimer.CRON_SCHEDULER_JOB_EXECUTION_TIME_MS,
(System.currentTimeMillis() - jobStartTime),
TimeUnit.MILLISECONDS);
```
and that sets the following as the metric table + taskType:
```
public static String getCronJobName(String tableWithType, String taskType)
{
return String.format("%s.%s", tableWithType, taskType);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
