somandal opened a new pull request, #15330:
URL: https://github.com/apache/pinot/pull/15330
Today the two controller timers `tableRebalanceExecutionTimeMs` and
`cronSchedulerJobExecutionTimeMs` are showing up in Prometheus with the
following type of metric names:
-
`pinot_controller_myTable_REALTIME_95thPercentile{status="tableRebalanceExecutionTimeMs",taskType="DONE"}`
The actual metric name is showing up as a label, whereas the metric name
seems to contain the table name. This is not the correct naming scheme for
these metrics and it is hard to create dashboards for such metrics.
This PR copies over the metric definitions for each of these from
`pinot.yml` to `controller.yml` and adds tests. The new metrics will show up as
follows in Prometheus:
-
`pinot_controller_tableRebalanceExecutionTimeMs_Count{status="DONE",table="myTable_REALTIME"}`
cc @suddendust @klsince @Jackie-Jiang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
