KKcorps commented on code in PR #15241:
URL: https://github.com/apache/pinot/pull/15241#discussion_r1989034312
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/SegmentCompletionFSMFactory.java:
##########
@@ -34,9 +34,10 @@ private SegmentCompletionFSMFactory() {
private static final Logger LOGGER =
LoggerFactory.getLogger(SegmentCompletionFSMFactory.class);
private static final Map<String, Class<? extends SegmentCompletionFSM>>
FSM_CLASS_MAP = new HashMap<>();
- // Static block to register the default FSM
+ // Static block to register the default FSM and pauseless FSM
static {
register(SegmentCompletionConfig.DEFAULT_FSM_SCHEME,
BlockingSegmentCompletionFSM.class);
+ register(SegmentCompletionConfig.DEFAULT_PAUSELESS_FSM_SCHEME,
PauselessSegmentCompletionFSM.class);
Review Comment:
register this against `fsm.scheme.pauseles` instead of this newly introduced
key.
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/SegmentCompletionFSMFactory.java:
##########
@@ -34,9 +34,10 @@ private SegmentCompletionFSMFactory() {
private static final Logger LOGGER =
LoggerFactory.getLogger(SegmentCompletionFSMFactory.class);
private static final Map<String, Class<? extends SegmentCompletionFSM>>
FSM_CLASS_MAP = new HashMap<>();
- // Static block to register the default FSM
+ // Static block to register the default FSM and pauseless FSM
static {
register(SegmentCompletionConfig.DEFAULT_FSM_SCHEME,
BlockingSegmentCompletionFSM.class);
+ register(SegmentCompletionConfig.DEFAULT_PAUSELESS_FSM_SCHEME,
PauselessSegmentCompletionFSM.class);
Review Comment:
register this against existing `fsm.scheme.pauseless` instead of this newly
introduced key.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
