9aman commented on code in PR #15241:
URL: https://github.com/apache/pinot/pull/15241#discussion_r1988556630
##########
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/PauselessRealtimeIngestionCommitEndMetadataFailureTest.java:
##########
@@ -57,6 +64,21 @@ public void testSegmentAssignment()
String tableNameWithType =
TableNameBuilder.REALTIME.tableNameWithType(getTableName());
PauselessRealtimeTestUtils.verifyIdealState(tableNameWithType,
NUM_REALTIME_SEGMENTS, _helixManager);
+ // the setup() function only waits till all the documents have been loaded
+ // this has lead to race condition in the commit protocol and validation
manager run leading to test failures
+ // checking the completion of the commit protocol i.e. segment marked
COMMITTING before triggering
+ // validation manager in the tests prevents this.
+
+ // All the segments should be in COMMITTING state for pauseless table
having commitEndMetadata failure
+ TestUtils.waitForCondition((aVoid) -> {
Review Comment:
This tests also ensures that we are using PauslessFsm as the DefaultFsm does
not mark the segments COMMITTING in the ZK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
