9aman commented on code in PR #15241:
URL: https://github.com/apache/pinot/pull/15241#discussion_r1988555060
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/SegmentCompletionManager.java:
##########
@@ -138,7 +139,8 @@ private SegmentCompletionFSM createFsm(LLCSegmentName
llcSegmentName, String msg
}
if (factoryName == null) {
- factoryName = _segmentCompletionConfig.getDefaultFsmScheme();
+ factoryName = PauselessConsumptionUtils.isPauselessEnabled(tableConfig)
Review Comment:
We are taking a call here on whether to use default pauseless fsm or default
fsm. Thus the user need not specify these two FSM's for pausless and normal
realtime tables.
Any other custom implementation would require
- registering the FSM
- Adding it to table config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
