gortiz commented on code in PR #15180:
URL: https://github.com/apache/pinot/pull/15180#discussion_r1979183957
##########
pinot-core/src/main/java/org/apache/pinot/core/query/executor/ServerQueryExecutorV1Impl.java:
##########
@@ -142,25 +140,8 @@ public synchronized void shutDown() {
@Override
public InstanceResponseBlock execute(ServerQueryRequest queryRequest,
ExecutorService executorService,
@Nullable ResultsBlockStreamer streamer) {
- MdcExecutor mdcExecutor = new MdcExecutor(executorService) {
- @Override
- protected boolean alreadyRegistered() {
- return LoggerConstants.QUERY_ID_KEY.isRegistered();
- }
-
- @Override
- protected void registerInMdc() {
- queryRequest.registerInMdc();
- }
-
- @Override
- protected void unregisterFromMdc() {
- queryRequest.unregisterFromMdc();
- }
- };
Review Comment:
We don't need to set MDC here because we already did it when setting
QueryThreadContext.setIds
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
