gortiz commented on code in PR #15180:
URL: https://github.com/apache/pinot/pull/15180#discussion_r1979127329
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java:
##########
@@ -121,82 +122,89 @@ public BaseBrokerRequestHandler(PinotConfiguration
config, String brokerId, Brok
public BrokerResponse handleRequest(JsonNode request, @Nullable
SqlNodeAndOptions sqlNodeAndOptions,
@Nullable RequesterIdentity requesterIdentity, RequestContext
requestContext, @Nullable HttpHeaders httpHeaders)
throws Exception {
- requestContext.setBrokerId(_brokerId);
- long requestId = _requestIdGenerator.get();
- requestContext.setRequestId(requestId);
+ try (QueryThreadContext.CloseableContext closeMe =
QueryThreadContext.open()) {
Review Comment:
Given that I had to introduce a try-with-resources here, I recommend to
review this class with the hide whitespace option in GH
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
