gortiz commented on code in PR #15143: URL: https://github.com/apache/pinot/pull/15143#discussion_r1973696575
########## pinot-core/src/test/java/org/apache/pinot/core/query/executor/MaxTasksExecutorTest.java: ########## @@ -0,0 +1,74 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.core.query.executor; + +import java.util.concurrent.Executors; +import java.util.concurrent.Semaphore; +import java.util.concurrent.TimeUnit; +import org.testng.annotations.Test; + +import static org.testng.AssertJUnit.*; + + +public class MaxTasksExecutorTest { + + private static final int MAX_TASKS = 5; + + @Test + public void testExecutor() { + MaxTasksExecutor ex = new MaxTasksExecutor(MAX_TASKS, Executors.newCachedThreadPool()); + + final Semaphore sem1 = new Semaphore(0); + final Semaphore sem2 = new Semaphore(0); + final Semaphore sem3 = new Semaphore(0); + + for (int i = 1; i <= MAX_TASKS; i++) { + ex.execute(() -> { + sem2.release(); + sem1.acquireUninterruptibly(); + sem3.release(); + }); + } + + try { + ex.execute(() -> { + }); + fail("Should not allow more than " + MAX_TASKS + " threads"); + } catch (Exception e) { + // as expected + } + + for (int i = MAX_TASKS; i > 0; i--) { + sem1.release(); + } + + try { + sem3.tryAcquire(MAX_TASKS, 10, TimeUnit.SECONDS); + } catch (InterruptedException e) { + fail("Interrupted waiting for tasks to complete"); + } + + try { + ex.execute(() -> { + }); + } catch (Exception e) { + fail("Exception submitting task after release: " + e); + } + } Review Comment: What is this test actually testing? It looks like it is trying too much. Couldn't you add a simple test with a single executor using 1 max tasks, use a lock and/or barrier to block the task and then ask schedule two tasks from the thread test. In order to test that you are throwing IllegalStateException even before the thread is consumed, I think it may be better to do that in another test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
