Jackie-Jiang commented on PR #14972: URL: https://github.com/apache/pinot/pull/14972#issuecomment-2685996914
@yashmayya > Are there any benchmark results showing performance improvements? I've tested it in a custom build release and observed good performance when all keys are unique (iirc over 100% boost) > I remember some other case where these primitive specific structures like Double2ObjectOpenHashMap were giving us much worse performance than a regular HashMap (although IIRC that was just for the build phase and not the lookup phase). I guess it is due to the slower rehash (open map re-calculate the hash for all entries during rehash, java map caches the hash code for all entries), and that is why I didn't use open map when the key is `Object`. `Object2IntOpenHashMap` might give much worse performance comparing to regular java map, but primitive key open map should be fine. Are you sure you observed much worse performance for primitive double open map? It should be super rare for user to join on a float/double key though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
