Jackie-Jiang commented on code in PR #14972: URL: https://github.com/apache/pinot/pull/14972#discussion_r1971092931
########## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/join/LookupTable.java: ########## @@ -0,0 +1,100 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.query.runtime.operator.join; + +import java.util.ArrayList; +import java.util.Collections; +import java.util.List; +import java.util.Map; +import java.util.Set; +import javax.annotation.Nullable; + + +public abstract class LookupTable { + // TODO: Make it configurable + protected static final int INITIAL_CAPACITY = 10000; + + protected boolean _keysUnique = true; + + /** + * Adds a row to the lookup table. + */ + public abstract void addRow(Object key, Object[] row); + + @SuppressWarnings("unchecked") + protected Object calculateValue(Object[] row, @Nullable Object currentValue) { + if (currentValue == null) { + return row; + } else { + _keysUnique = false; + if (currentValue instanceof List) { + ((List<Object[]>) currentValue).add(row); + return currentValue; + } else { + List<Object[]> rows = new ArrayList<>(); + rows.add((Object[]) currentValue); + rows.add(row); + return rows; + } + } + } + + /** + * Finishes adding rows to the lookup table. This method should be called after all rows are added to the lookup + * table, and before looking up rows. + */ + public abstract void finish(); + + protected static void convertValueToList(Map.Entry<?, Object> entry) { + Object value = entry.getValue(); + if (value instanceof Object[]) { + entry.setValue(Collections.singletonList(value)); + } + } + + /** + * Returns {@code true} when all the keys added to the lookup table are unique. + * When all keys are unique, the value of the lookup table is a single row ({@code Object[]}). When keys are not + * unique, the value of the lookup table is a list of rows ({@code List<Object[]>}). + */ + public boolean isKeysUnique() { Review Comment: `is` prefix is kind of a convention for method returning `boolean`, so I prefer keeping it this way here -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
