Jackie-Jiang commented on code in PR #14972: URL: https://github.com/apache/pinot/pull/14972#discussion_r1971085572
########## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/join/DoubleLookupTable.java: ########## @@ -0,0 +1,65 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.query.runtime.operator.join; + +import it.unimi.dsi.fastutil.doubles.Double2ObjectMap; +import it.unimi.dsi.fastutil.doubles.Double2ObjectOpenHashMap; +import java.util.Map; +import java.util.Set; +import javax.annotation.Nullable; + + +/** + * The {@code DoubleLookupTable} is a lookup table for double keys. + */ +@SuppressWarnings("unchecked") +public class DoubleLookupTable extends LookupTable { + private final Double2ObjectOpenHashMap<Object> _lookupTable = new Double2ObjectOpenHashMap<>(INITIAL_CAPACITY); + + @Override + public void addRow(Object key, Object[] row) { + _lookupTable.compute((double) key, (k, v) -> calculateValue(row, v)); + } + + @Override + public void finish() { + if (!_keysUnique) { + for (Double2ObjectMap.Entry<Object> entry : _lookupTable.double2ObjectEntrySet()) { + convertValueToList(entry); + } + } + } + + @Override + public boolean containsKey(Object key) { + return _lookupTable.containsKey((double) key); + } + + @Nullable + @Override + public Object[] lookup(Object key) { + return (Object[]) _lookupTable.get((double) key); Review Comment: Good catch! Fixed ########## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/join/FloatLookupTable.java: ########## @@ -0,0 +1,65 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.query.runtime.operator.join; + +import it.unimi.dsi.fastutil.floats.Float2ObjectMap; +import it.unimi.dsi.fastutil.floats.Float2ObjectOpenHashMap; +import java.util.Map; +import java.util.Set; +import javax.annotation.Nullable; + + +/** + * The {@code FloatLookupTable} is a lookup table for float keys. + */ +@SuppressWarnings("unchecked") +public class FloatLookupTable extends LookupTable { + private final Float2ObjectOpenHashMap<Object> _lookupTable = new Float2ObjectOpenHashMap<>(INITIAL_CAPACITY); + + @Override + public void addRow(Object key, Object[] row) { + _lookupTable.compute((float) key, (k, v) -> calculateValue(row, v)); + } + + @Override + public void finish() { + if (!_keysUnique) { + for (Float2ObjectMap.Entry<Object> entry : _lookupTable.float2ObjectEntrySet()) { + convertValueToList(entry); + } + } + } + + @Override + public boolean containsKey(Object key) { + return _lookupTable.containsKey((float) key); + } + + @Nullable + @Override + public Object[] lookup(Object key) { + return (Object[]) _lookupTable.get((float) key); Review Comment: Good catch! Fixed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
