gortiz commented on code in PR #15072:
URL: https://github.com/apache/pinot/pull/15072#discussion_r1969850229
##########
pinot-tools/src/main/resources/log4j2.xml:
##########
@@ -23,7 +23,12 @@
<Properties>
<Property name="LOG_ROOT">logs</Property>
- <Property name="LOG_PATTERN">%d{yyyy/MM/dd HH:mm:ss.SSS} %p [%c{1}] [%t]
%m%n</Property>
+ <!--
+ See
+
https://logging.apache.org/log4j/2.x/manual/pattern-layout.html#converter-not-empty
+ and
https://logging.apache.org/log4j/2.x/manual/pattern-layout.html#converter-thread-context-map
+ -->
Review Comment:
It is another contextual variable I'm using in the PR where I'm improving
errors. There I'm using that to say whether the log comes from a server,
controller or broker, which is very useful in Quickstarts where all logs are
merged. But shouldn't be used here. I'm removing it.
##########
pinot-spi/src/main/java/org/apache/pinot/spi/executor/DecoratorExecutorService.java:
##########
@@ -0,0 +1,163 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.spi.executor;
+
+import java.util.Collection;
+import java.util.List;
+import java.util.concurrent.Callable;
+import java.util.concurrent.ExecutionException;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Future;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.TimeoutException;
+import java.util.stream.Collectors;
+
+/**
+ * DecoratorExecutorService is an abstract class that provides a way to
decorate an ExecutorService with additional
+ * functionality.
+ *
+ * TODO: Convert this class and its usages into an Executor instead of an
ExecutorService
+ */
+public abstract class DecoratorExecutorService implements ExecutorService {
+ private final ExecutorService _executorService;
+
+ public DecoratorExecutorService(ExecutorService executorService) {
+ _executorService = executorService;
+ }
+
+ protected abstract <T> Callable<T> decorate(Callable<T> task);
+
+ protected abstract Runnable decorate(Runnable task);
+
+ protected <T> Collection<? extends Callable<T>> decorateTasks(Collection<?
extends Callable<T>> tasks) {
Review Comment:
Added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
