yashmayya commented on code in PR #15072: URL: https://github.com/apache/pinot/pull/15072#discussion_r1969390425
########## pinot-spi/src/main/java/org/apache/pinot/spi/trace/LoggerConstants.java: ########## @@ -0,0 +1,65 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.spi.trace; + +import org.slf4j.MDC; + + +public enum LoggerConstants { + + QUERY_ID_KEY("pinot.query.id"), + /** + * The MSE worker id of the query. + */ + WORKER_ID_KEY("pinot.mse.workerId"), + /** + * The MSE stage id of the query. + */ + STAGE_ID_KEY("pinot.mse.stageId"); + + private final String _key; + + LoggerConstants(String key) { + _key = key; + } + + public String getKey() { + return _key; + } + + public void registerOnMdc(String value) { + registerOnMdcIfNotSet(value, false); + } + + public boolean registerOnMdcIfNotSet(String value, boolean override) { Review Comment: What situations would we want to override the MDC value in? Currently we're not overriding in any case right? And we're simply logging if we see some MDC value already registered unexpectedly (potentially from missed cleanup earlier)? Shouldn't we override it in that case instead of using the older stale value? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
