gortiz commented on code in PR #15072: URL: https://github.com/apache/pinot/pull/15072#discussion_r1969779895
########## pinot-core/src/main/java/org/apache/pinot/core/query/executor/ServerQueryExecutorV1Impl.java: ########## @@ -140,8 +142,25 @@ public synchronized void shutDown() { @Override public InstanceResponseBlock execute(ServerQueryRequest queryRequest, ExecutorService executorService, @Nullable ResultsBlockStreamer streamer) { + MdcExecutor mdcExecutor = new MdcExecutor(executorService) { Review Comment: Yes, it is easier and safer to do it this way. This allocation is super cheap, given we just decorate an actual executor and the decorator has almost no state -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org