vrajat commented on code in PR #15005:
URL: https://github.com/apache/pinot/pull/15005#discussion_r1954158892
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/MultiStageBrokerRequestHandler.java:
##########
@@ -104,17 +110,21 @@ public class MultiStageBrokerRequestHandler extends
BaseBrokerRequestHandler {
public MultiStageBrokerRequestHandler(PinotConfiguration config, String
brokerId, BrokerRoutingManager routingManager,
AccessControlFactory accessControlFactory, QueryQuotaManager
queryQuotaManager, TableCache tableCache,
- MultiStageQueryThrottler queryThrottler) {
+ MultiStageQueryThrottler queryThrottler, FailureDetector
failureDetector) {
super(config, brokerId, routingManager, accessControlFactory,
queryQuotaManager, tableCache);
String hostname =
config.getProperty(CommonConstants.MultiStageQueryRunner.KEY_OF_QUERY_RUNNER_HOSTNAME);
int port =
Integer.parseInt(config.getProperty(CommonConstants.MultiStageQueryRunner.KEY_OF_QUERY_RUNNER_PORT));
- _workerManager = new WorkerManager(hostname, port, _routingManager);
+ _workerManager = new
WorkerManager(config.getProperty(CommonConstants.Broker.CONFIG_OF_BROKER_ID),
hostname, port,
Review Comment:
nit: there is already a `_brokerId` available in the parent class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
