yashmayya commented on code in PR #15005:
URL: https://github.com/apache/pinot/pull/15005#discussion_r1945118622
##########
pinot-common/src/main/java/org/apache/pinot/common/failuredetector/ConnectionFailureDetector.java:
##########
@@ -16,29 +16,18 @@
* specific language governing permissions and limitations
* under the License.
*/
-package org.apache.pinot.broker.failuredetector;
+package org.apache.pinot.common.failuredetector;
import javax.annotation.concurrent.ThreadSafe;
-import org.apache.pinot.core.transport.QueryResponse;
-import org.apache.pinot.core.transport.ServerRoutingInstance;
/**
* The {@code ConnectionFailureDetector} marks failed server (connection
failure) from query response as unhealthy, and
* retries the unhealthy servers with exponential increasing delays.
+ * <p>
+ * This class doesn't currently implement any additional logic over
BaseExponentialBackoffRetryFailureDetector and is
+ * retained for backward compatibility.
Review Comment:
On second thought we could probably remove this class altogether since the
class name is not exposed via the user configuration directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
