gortiz commented on code in PR #15005:
URL: https://github.com/apache/pinot/pull/15005#discussion_r1954105248
##########
pinot-common/src/main/java/org/apache/pinot/common/failuredetector/BaseExponentialBackoffRetryFailureDetector.java:
##########
@@ -88,21 +102,28 @@ public void start() {
LOGGER.info("Server: {} has been marked healthy, skipping the
retry", instanceId);
continue;
}
- if (retryInfo._numRetires == _maxRetries) {
+ if (retryInfo._numRetries == _maxRetries) {
LOGGER.warn("Unhealthy server: {} already reaches the max retries:
{}, do not retry again and treat it "
+ "as healthy so that the listeners do not lose track of the
server", instanceId, _maxRetries);
markServerHealthy(instanceId);
continue;
}
LOGGER.info("Retry unhealthy server: {}", instanceId);
- for (Listener listener : _listeners) {
- listener.retryUnhealthyServer(instanceId, this);
+ boolean recovered = true;
+ for (Function<String, Boolean> unhealthyServerRetrier :
_unhealthyServerRetriers) {
+ if (!unhealthyServerRetrier.apply(instanceId)) {
+ recovered = false;
Review Comment:
I was just going to comment about this section when it was written the other
way around, but it looks like you just changed it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
