somandal commented on code in PR #14960:
URL: https://github.com/apache/pinot/pull/14960#discussion_r1937499997
##########
pinot-controller/src/main/java/org/apache/pinot/controller/BaseControllerStarter.java:
##########
@@ -300,6 +300,10 @@ private void setupHelixSystemProperties() {
}
private void setupHelixClusterConstraints() {
+ setupInstanceMaxStateTransitions();
+ }
+
+ protected void setupInstanceMaxStateTransitions() {
Review Comment:
Instead of this, can't we just override the following property with a new
default from the class that extends this one?:
```
public static final String
CONFIG_OF_HELIX_INSTANCE_MAX_STATE_TRANSITIONS =
"pinot.helix.instance.state.maxStateTransitions";
```
You'd need to override the default in the init() function in that case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
