deepthi912 commented on code in PR #14960:
URL: https://github.com/apache/pinot/pull/14960#discussion_r1937548486
##########
pinot-controller/src/main/java/org/apache/pinot/controller/BaseControllerStarter.java:
##########
@@ -300,6 +300,10 @@ private void setupHelixSystemProperties() {
}
private void setupHelixClusterConstraints() {
+ setupInstanceMaxStateTransitions();
+ }
+
+ protected void setupInstanceMaxStateTransitions() {
Review Comment:
We could do that but not for every controller mode this was not applicable
which is why I tried to make this method extendable for easy navigation:
If you see :
```
switch (_controllerMode) {
case DUAL:
setUpHelixController();
setUpPinotController();
break;
case PINOT_ONLY:
setUpPinotController();
break;
case HELIX_ONLY:
setUpHelixController();
break;
default:
LOGGER.error("Invalid mode: {}", _controllerMode);
break;
}
```
DUAL, HELIX_ONLY --- Yes the other way around overridePropertyIfExists also
works!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
