somandal commented on code in PR #14960:
URL: https://github.com/apache/pinot/pull/14960#discussion_r1937559296
##########
pinot-controller/src/main/java/org/apache/pinot/controller/BaseControllerStarter.java:
##########
@@ -300,6 +300,10 @@ private void setupHelixSystemProperties() {
}
private void setupHelixClusterConstraints() {
+ setupInstanceMaxStateTransitions();
+ }
+
+ protected void setupInstanceMaxStateTransitions() {
Review Comment:
Would that matter though, if all the controllers set the same property
default? the Dual/Helix only one will pick it up, right? every cluster has to
have at least one Pinot controller with Dual/Helix only? but maybe I'm missing
something. Good to see if you can try it out with a couple of controllers on
your dev machine?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
