jackjlli commented on a change in pull request #4047: Create
leadControllerResource in helix cluster
URL: https://github.com/apache/incubator-pinot/pull/4047#discussion_r290062469
##########
File path:
pinot-controller/src/test/java/org/apache/pinot/controller/helix/PinotControllerModeTest.java
##########
@@ -67,6 +72,25 @@ public void testDualModeController()
"Failed to start " + config.getControllerMode() + " controller in " +
TIMEOUT_IN_MS + "ms.");
Assert.assertEquals(_controllerStarter.getControllerMode(),
ControllerConf.ControllerMode.DUAL);
+ // Enable the lead controller resource.
Review comment:
Check the test code. There's a method called `protected void
startController(ControllerConf config, boolean deleteCluster)`. If
`deleteCluster` is true, it'll wipe out the existing cluster info. So no need
to implement a wipe out method any more.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
