mariofusco commented on PR #6298: URL: https://github.com/apache/incubator-kie-drools/pull/6298#issuecomment-2785729900
> FYI, I run tests with another approach "Allow RIA sharing even with different agenda-group" #6301 All tests passed including `SubnetworkTest.testSubnetworkSharingWith2Sinks` which was added on [8c3b65f](https://github.com/apache/incubator-kie-drools/commit/8c3b65fc0cb6f437217216c718d2e1b5d0ec27e4) This approach wouldn't yield the benefit of unused-code-cleanup, but if you are intersted in it, let me know. I'll dig deeper why `SubnetworkTest.testSubnetworkSharingWith2Sinks` doesn't fail now. That's great, and to be honest this solution makes much more sense to me. I honestly don't remember why I prevented sharing of `RightInputAdapterNodes` when they belong to different agenda-groups (according to that commit I did it more than 7 years ago), but very likely that was a (ugly) workaround for something that has been fixed in a better way in the meantime. If sharing `RightInputAdapterNodes` in different agenda-groups doesn't cause any regression or test failures, I would definitively go with this solution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
