tkobayas commented on PR #6298:
URL:
https://github.com/apache/incubator-kie-drools/pull/6298#issuecomment-2785486155
Hi @mariofusco , I disabled the RightInputAdapterNode sharing and the
following tests failed.
- Expected failure (Node or memory assertion): Tests are fixed
- AccumulateMvelDialectTest.testAccumulateWithSameSubnetwork
-
ActivateAndDeleteOnListenerTest.testOneLazyAndOneImmediateSubPathAfterLia
- LinkingTest.testNonReactiveSubNetworkOwnSegmentMasks
- PathEndNodeTest.testSubNetworkSharing
- Unexpected failure: Tests are not fixed yet
-
AddRemoveRulesTest.testRemoveWithSplitStartAfterSubnetwork3RulesReaddRule
- AddRemoveRulesTest.testRemoveRuleWithSharedRia
The unexpected failures might be a regression. EagerPhreakBuilder doesn't
create/clean peer for non-shared RightInputAdapterNode when
`addRule`/`removeRule` is called. IMO, EagerPhreakBuilder has been focusing on
shared RightInputAdapterNode use case and hasn't tested non-shared
RightInputAdapterNode well. If you think EagerPhreakBuilder has to be fixed,
let me know. I'll work on it.
FYI, I run tests with another approach "Allow RIA sharing even with
different agenda-group"
https://github.com/apache/incubator-kie-drools/pull/6301 All tests passed
including `SubnetworkTest.testSubnetworkSharingWith2Sinks` which was added on
https://github.com/apache/incubator-kie-drools/commit/8c3b65fc0cb6f437217216c718d2e1b5d0ec27e4
This approach wouldn't yield the benefit of unused-code-cleanup, but if you
are intersted in it, let me know. I'll dig deeper why
`SubnetworkTest.testSubnetworkSharingWith2Sinks` doesn't fail now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
