mariofusco commented on PR #6298: URL: https://github.com/apache/incubator-kie-drools/pull/6298#issuecomment-2778293338
> * If `BuildUtils.areNodesCompatibleForSharing` always returns false for RightInputAdapterNode, creating peer in `doRiaNode2` wouldn't be triggered. Of course not sharing RightInputAdapterNode would have performance impact (but not so big?). https://github.com/apache/incubator-kie-drools/blob/10.0.0/drools-core/src/main/java/org/drools/core/reteoo/builder/BuildUtils.java#L186-L197 I gave a look at this and I agree that avoiding sharing the `RightInputAdapterNode` would be the clearest and easiest to maintain fix for this issue and probably has a negligible impact on performances. Can you please try to implement this and double check that it fixes the problem and doesn't cause other regressions? I also suspect that avoid this sharing could allow us to simplify our code in other places, but let's do this one step at time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
