geyanggang commented on code in PR #10789:
URL: https://github.com/apache/gravitino/pull/10789#discussion_r3172573082
##########
catalogs/hive-metastore2-libs/build.gradle.kts:
##########
@@ -29,27 +29,35 @@ plugins {
// Guava and Logback are excluded because they are provided by the Gravitino
runtime classpath.
dependencies {
- implementation(libs.hadoop2.common) {
+ implementation(libs.hadoop3.common) {
exclude(group = "ch.qos.logback")
+ exclude(group = "ch.qos.reload4j")
exclude(group = "com.fasterxml.jackson.core")
+ exclude(group = "com.github.pjfanning", module = "jersey-json")
exclude(group = "com.github.spotbugs")
exclude(group = "com.google.code.findbugs")
exclude(group = "com.google.guava")
+ exclude(group = "com.sun.jersey")
exclude(group = "log4j")
exclude(group = "net.java.dev.jets3t")
exclude(group = "org.apache.avro")
exclude(group = "org.apache.logging.log4j")
+ exclude(group = "org.eclipse.jetty")
exclude(group = "org.eclipse.jetty.aggregate", module = "jetty-all")
exclude(group = "org.eclipse.jetty.orbit", module = "javax.servlet")
exclude(group = "org.slf4j")
}
- implementation(libs.hadoop2.mapreduce.client.core) {
+ implementation(libs.hadoop3.mapreduce.client.core) {
Review Comment:
Hive2 metastore has a compile-scope dependency on mapreduce-client-core
(uses JobConf, etc.), while Hive3 standalone-metastore only needs it as
provided or not at all. That's why hive-metastore2-libs has had this dependency
since the initial shim (74e9881), and hive-metastore3-libs never did. This line
just bumps it from hadoop2 → hadoop3 — no functional change.
##########
catalogs/hive-metastore2-libs/build.gradle.kts:
##########
@@ -29,27 +29,35 @@ plugins {
// Guava and Logback are excluded because they are provided by the Gravitino
runtime classpath.
dependencies {
- implementation(libs.hadoop2.common) {
+ implementation(libs.hadoop3.common) {
exclude(group = "ch.qos.logback")
+ exclude(group = "ch.qos.reload4j")
exclude(group = "com.fasterxml.jackson.core")
+ exclude(group = "com.github.pjfanning", module = "jersey-json")
exclude(group = "com.github.spotbugs")
exclude(group = "com.google.code.findbugs")
exclude(group = "com.google.guava")
+ exclude(group = "com.sun.jersey")
exclude(group = "log4j")
exclude(group = "net.java.dev.jets3t")
exclude(group = "org.apache.avro")
exclude(group = "org.apache.logging.log4j")
+ exclude(group = "org.eclipse.jetty")
exclude(group = "org.eclipse.jetty.aggregate", module = "jetty-all")
exclude(group = "org.eclipse.jetty.orbit", module = "javax.servlet")
exclude(group = "org.slf4j")
}
- implementation(libs.hadoop2.mapreduce.client.core) {
+ implementation(libs.hadoop3.mapreduce.client.core) {
Review Comment:
This difference predates this PR — hadoop-mapreduce-client-core was added to
hive-metastore2-libs in a previous PR (#10457) to shrink package size, but was
never added to hive-metastore3-libs. Hive 2 metastore requires some MapReduce
client classes that Hive 3 metastore doesn't depend on directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
