geyanggang commented on code in PR #10789:
URL: https://github.com/apache/gravitino/pull/10789#discussion_r3153608155
##########
catalogs/catalog-hive/build.gradle.kts:
##########
@@ -49,12 +49,17 @@ dependencies {
implementation(libs.commons.io)
implementation(libs.commons.lang3)
implementation(libs.guava)
- implementation(libs.hadoop2.auth) {
+ implementation(libs.hadoop3.auth) {
exclude("*")
}
- implementation(libs.hadoop2.common) {
+ implementation(libs.hadoop3.common) {
exclude("*")
}
+ // Hadoop 3.x runtime requirements (stripped by exclude("*") above)
+ implementation(libs.hadoop3.shaded.guava)
+ implementation(libs.hadoop3.shaded.protobuf)
+ implementation(libs.commons.configuration2)
+ implementation(libs.re2j)
Review Comment:
`re2j` is a new compile dependency in Hadoop 3 (not present in Hadoop 2).
It's used by `GlobPattern` and `GlobFilter` in `hadoop-common`, which are on
the `FileSystem.globStatus()` code path. Without it, we get
`NoClassDefFoundError: com/google/re2j/PatternSyntaxException` at runtime.
##########
trino-connector/integration-test/build.gradle.kts:
##########
@@ -41,11 +41,20 @@ dependencies {
testImplementation(libs.bundles.jetty)
testImplementation(libs.bundles.log4j)
testImplementation(libs.commons.cli)
- testImplementation(libs.hadoop2.common) {
+ testImplementation(libs.hadoop3.common) {
exclude("*")
}
- testImplementation(libs.hadoop2.hdfs)
- testImplementation(libs.hadoop2.mapreduce.client.core) {
+ testImplementation(libs.hadoop3.hdfs)
+ testImplementation(libs.hadoop3.hdfs.client)
+ testImplementation(libs.hadoop3.mapreduce.client.core) {
+ exclude("*")
+ }
+ // Hadoop 3.x runtime requirements (stripped by exclude("*") above)
+ testImplementation(libs.hadoop3.shaded.guava)
+ testImplementation(libs.hadoop3.shaded.protobuf)
+ testImplementation(libs.commons.configuration2)
+ testImplementation(libs.re2j)
+ testImplementation(libs.hadoop3.mapreduce.client.core) {
exclude("*")
}
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
