Copilot commented on code in PR #10789:
URL: https://github.com/apache/gravitino/pull/10789#discussion_r3153527137
##########
trino-connector/integration-test/build.gradle.kts:
##########
@@ -41,11 +41,20 @@ dependencies {
testImplementation(libs.bundles.jetty)
testImplementation(libs.bundles.log4j)
testImplementation(libs.commons.cli)
- testImplementation(libs.hadoop2.common) {
+ testImplementation(libs.hadoop3.common) {
exclude("*")
}
- testImplementation(libs.hadoop2.hdfs)
- testImplementation(libs.hadoop2.mapreduce.client.core) {
+ testImplementation(libs.hadoop3.hdfs)
+ testImplementation(libs.hadoop3.hdfs.client)
+ testImplementation(libs.hadoop3.mapreduce.client.core) {
+ exclude("*")
+ }
+ // Hadoop 3.x runtime requirements (stripped by exclude("*") above)
+ testImplementation(libs.hadoop3.shaded.guava)
+ testImplementation(libs.hadoop3.shaded.protobuf)
+ testImplementation(libs.commons.configuration2)
+ testImplementation(libs.re2j)
+ testImplementation(libs.hadoop3.mapreduce.client.core) {
exclude("*")
}
Review Comment:
`libs.hadoop3.mapreduce.client.core` is declared twice (once earlier in this
dependencies block and again here). This is redundant and can make it harder to
reason about the effective excludes; remove the duplicate declaration (or, if a
different runtime dependency was intended, add that instead).
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
