yuqi1129 commented on code in PR #10081:
URL: https://github.com/apache/gravitino/pull/10081#discussion_r3093426054
##########
catalogs/catalog-lakehouse-iceberg/src/main/java/org/apache/gravitino/catalog/lakehouse/iceberg/IcebergCatalog.java:
##########
@@ -81,4 +94,67 @@ public PropertiesMetadata catalogPropertiesMetadata() throws
UnsupportedOperatio
public PropertiesMetadata schemaPropertiesMetadata() throws
UnsupportedOperationException {
return SCHEMA_PROPERTIES_META;
}
+
+ @Override
Review Comment:
This only adds credential providers for the JDBC backend. But Iceberg
catalogs with non-JDBC backends (e.g., Hive metastore or REST) can also use
S3/OSS/Azure for table storage. Should the S3/OSS/Azure credential provider
detection be applied regardless of the catalog backend type? The current logic
skips storage credential vending entirely for non-JDBC backends, which seems
like an unnecessary limitation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
