yuqi1129 commented on code in PR #10081:
URL: https://github.com/apache/gravitino/pull/10081#discussion_r2966498009
##########
core/src/main/java/org/apache/gravitino/connector/BaseCatalog.java:
##########
@@ -421,6 +422,16 @@ public Map<String, String> properties() {
return properties;
}
+ /**
+ * Retrieves the properties of the catalog including credential providers.
This method is used
+ * when we need to expose credential-related properties.
+ *
+ * @return A map of properties including credential providers.
+ */
+ public Map<String, String> propertiesWithCredentialProviders() {
+ return properties();
Review Comment:
The default implementation returning `properties()` is a safe fallback and
the Javadoc is clear. One suggestion: the Javadoc says "This method is called
when we need to expose credential-related properties" — it would be more
precise to say:
> Subclasses should override this method to inject auto-detected credential
provider names into the properties map before the `CatalogCredentialManager` is
initialized. The default implementation returns `properties()` unchanged.
This helps future catalog implementors know exactly when/why to override
this hook.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
