yuqi1129 commented on code in PR #10081:
URL: https://github.com/apache/gravitino/pull/10081#discussion_r3093404868
##########
catalogs/catalog-lakehouse-paimon/src/main/java/org/apache/gravitino/catalog/lakehouse/paimon/PaimonCatalog.java:
##########
@@ -77,4 +90,67 @@ public PropertiesMetadata catalogPropertiesMetadata() throws
UnsupportedOperatio
public PropertiesMetadata schemaPropertiesMetadata() throws
UnsupportedOperationException {
return SCHEMA_PROPERTIES_META;
}
+
+ @Override
+ public Map<String, String> propertiesWithCredentialProviders() {
+ Map<String, String> properties =
Maps.newHashMap(super.propertiesWithCredentialProviders());
+ return buildCredentialProvidersIfNecessary(properties);
+ }
+
+ private Map<String, String> buildCredentialProvidersIfNecessary(Map<String,
String> properties) {
+ // If credential providers already set, return as is
+ if
(StringUtils.isNotBlank(properties.get(CredentialConstants.CREDENTIAL_PROVIDERS)))
{
+ return properties;
+ }
Review Comment:
Same here — `.toUpperCase(Locale.ROOT)` is redundant with
`equalsIgnoreCase`. Simplify to:
```java
if (!PaimonCatalogBackend.JDBC.name().equalsIgnoreCase(catalogBackend)) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
