This is an automated email from the ASF dual-hosted git repository. diqiu50 pushed a commit to branch glue-pr03 in repository https://gitbox.apache.org/repos/asf/gravitino.git
commit bd8724a6d050a8bc6d46c745f6a9a39dc7bc3f81 Author: diqiu50 <[email protected]> AuthorDate: Mon Apr 13 12:32:54 2026 +0800 refactor(catalog-glue): Rename TABLE_FORMAT_TYPE to TABLE_FORMAT, unify naming --- .../java/org/apache/gravitino/catalog/glue/GlueConstants.java | 9 ++++----- .../gravitino/catalog/glue/GlueTablePropertiesMetadata.java | 10 ---------- .../catalog/glue/TestGlueTablePropertiesMetadata.java | 11 ----------- 3 files changed, 4 insertions(+), 26 deletions(-) diff --git a/catalogs/catalog-glue/src/main/java/org/apache/gravitino/catalog/glue/GlueConstants.java b/catalogs/catalog-glue/src/main/java/org/apache/gravitino/catalog/glue/GlueConstants.java index f33f6c3c21..262ec3e866 100644 --- a/catalogs/catalog-glue/src/main/java/org/apache/gravitino/catalog/glue/GlueConstants.java +++ b/catalogs/catalog-glue/src/main/java/org/apache/gravitino/catalog/glue/GlueConstants.java @@ -69,12 +69,11 @@ public final class GlueConstants { // ------------------------------------------------------------------------- /** - * Glue table format type parameter key stored in {@code Table.parameters()}. Common values: - * {@code ICEBERG}, {@code HIVE}, {@code DELTA}, {@code PARQUET} (uppercase, as stored by Glue). - * Note: these differ from the Gravitino-side filter values in {@link #TABLE_FORMAT_FILTER}, which - * use lowercase (e.g. {@code iceberg}, {@code hive}). + * Glue table format parameter key stored in {@code Table.parameters()}. Common values: {@code + * ICEBERG}, {@code HIVE}, {@code DELTA}, {@code PARQUET} (uppercase, as stored by Glue). Used + * internally to determine the table format when reading Glue tables. */ - public static final String TABLE_FORMAT_TYPE = "table_format_type"; + public static final String TABLE_FORMAT = "table_format"; /** Iceberg table metadata location stored in Glue {@code Table.parameters()}. */ public static final String METADATA_LOCATION = "metadata_location"; diff --git a/catalogs/catalog-glue/src/main/java/org/apache/gravitino/catalog/glue/GlueTablePropertiesMetadata.java b/catalogs/catalog-glue/src/main/java/org/apache/gravitino/catalog/glue/GlueTablePropertiesMetadata.java index d6ddaa0202..0fe30c9046 100644 --- a/catalogs/catalog-glue/src/main/java/org/apache/gravitino/catalog/glue/GlueTablePropertiesMetadata.java +++ b/catalogs/catalog-glue/src/main/java/org/apache/gravitino/catalog/glue/GlueTablePropertiesMetadata.java @@ -19,7 +19,6 @@ package org.apache.gravitino.catalog.glue; import static org.apache.gravitino.catalog.glue.GlueConstants.METADATA_LOCATION; -import static org.apache.gravitino.catalog.glue.GlueConstants.TABLE_FORMAT_TYPE; import static org.apache.gravitino.connector.PropertyEntry.stringOptionalPropertyEntry; import com.google.common.collect.ImmutableMap; @@ -42,15 +41,6 @@ public class GlueTablePropertiesMetadata extends BasePropertiesMetadata { private static final Map<String, PropertyEntry<?>> PROPERTIES_METADATA = ImmutableMap.<String, PropertyEntry<?>>builder() - .put( - TABLE_FORMAT_TYPE, - stringOptionalPropertyEntry( - TABLE_FORMAT_TYPE, - "Glue table format type stored in Table.parameters(). Common values:" - + " iceberg, hive.", - false /* immutable */, - null /* defaultValue */, - false /* hidden */)) .put( METADATA_LOCATION, stringOptionalPropertyEntry( diff --git a/catalogs/catalog-glue/src/test/java/org/apache/gravitino/catalog/glue/TestGlueTablePropertiesMetadata.java b/catalogs/catalog-glue/src/test/java/org/apache/gravitino/catalog/glue/TestGlueTablePropertiesMetadata.java index b9bfa55a5a..582bfd1ff1 100644 --- a/catalogs/catalog-glue/src/test/java/org/apache/gravitino/catalog/glue/TestGlueTablePropertiesMetadata.java +++ b/catalogs/catalog-glue/src/test/java/org/apache/gravitino/catalog/glue/TestGlueTablePropertiesMetadata.java @@ -19,7 +19,6 @@ package org.apache.gravitino.catalog.glue; import static org.apache.gravitino.catalog.glue.GlueConstants.METADATA_LOCATION; -import static org.apache.gravitino.catalog.glue.GlueConstants.TABLE_FORMAT_TYPE; import static org.junit.jupiter.api.Assertions.assertFalse; import org.junit.jupiter.api.BeforeEach; @@ -34,16 +33,6 @@ class TestGlueTablePropertiesMetadata { metadata = new GlueTablePropertiesMetadata(); } - @Test - void testTableFormatTypeIsOptional() { - assertFalse(metadata.isRequiredProperty(TABLE_FORMAT_TYPE)); - } - - @Test - void testTableFormatTypeIsNotHidden() { - assertFalse(metadata.isHiddenProperty(TABLE_FORMAT_TYPE)); - } - @Test void testMetadataLocationIsOptional() { assertFalse(metadata.isRequiredProperty(METADATA_LOCATION));
