This is an automated email from the ASF dual-hosted git repository. diqiu50 pushed a commit to branch glue-pr03 in repository https://gitbox.apache.org/repos/asf/gravitino.git
commit 9787032830ab44911d68de29b10421a2f9592c87 Author: diqiu50 <[email protected]> AuthorDate: Mon Apr 13 12:47:24 2026 +0800 refactor(catalog-glue): restore TABLE_FORMAT in GlueTablePropertiesMetadata Declare table-format as an explicit optional property so it is visible and settable by users, rather than silently passed through. --- .../gravitino/catalog/glue/GlueTablePropertiesMetadata.java | 9 +++++++++ .../catalog/glue/TestGlueTablePropertiesMetadata.java | 11 +++++++++++ 2 files changed, 20 insertions(+) diff --git a/catalogs/catalog-glue/src/main/java/org/apache/gravitino/catalog/glue/GlueTablePropertiesMetadata.java b/catalogs/catalog-glue/src/main/java/org/apache/gravitino/catalog/glue/GlueTablePropertiesMetadata.java index 0fe30c9046..79236a1590 100644 --- a/catalogs/catalog-glue/src/main/java/org/apache/gravitino/catalog/glue/GlueTablePropertiesMetadata.java +++ b/catalogs/catalog-glue/src/main/java/org/apache/gravitino/catalog/glue/GlueTablePropertiesMetadata.java @@ -19,6 +19,7 @@ package org.apache.gravitino.catalog.glue; import static org.apache.gravitino.catalog.glue.GlueConstants.METADATA_LOCATION; +import static org.apache.gravitino.catalog.glue.GlueConstants.TABLE_FORMAT; import static org.apache.gravitino.connector.PropertyEntry.stringOptionalPropertyEntry; import com.google.common.collect.ImmutableMap; @@ -41,6 +42,14 @@ public class GlueTablePropertiesMetadata extends BasePropertiesMetadata { private static final Map<String, PropertyEntry<?>> PROPERTIES_METADATA = ImmutableMap.<String, PropertyEntry<?>>builder() + .put( + TABLE_FORMAT, + stringOptionalPropertyEntry( + TABLE_FORMAT, + "Table format stored in Table.parameters(). Common values: iceberg, hive.", + false /* immutable */, + null /* defaultValue */, + false /* hidden */)) .put( METADATA_LOCATION, stringOptionalPropertyEntry( diff --git a/catalogs/catalog-glue/src/test/java/org/apache/gravitino/catalog/glue/TestGlueTablePropertiesMetadata.java b/catalogs/catalog-glue/src/test/java/org/apache/gravitino/catalog/glue/TestGlueTablePropertiesMetadata.java index 582bfd1ff1..89322b5519 100644 --- a/catalogs/catalog-glue/src/test/java/org/apache/gravitino/catalog/glue/TestGlueTablePropertiesMetadata.java +++ b/catalogs/catalog-glue/src/test/java/org/apache/gravitino/catalog/glue/TestGlueTablePropertiesMetadata.java @@ -19,6 +19,7 @@ package org.apache.gravitino.catalog.glue; import static org.apache.gravitino.catalog.glue.GlueConstants.METADATA_LOCATION; +import static org.apache.gravitino.catalog.glue.GlueConstants.TABLE_FORMAT; import static org.junit.jupiter.api.Assertions.assertFalse; import org.junit.jupiter.api.BeforeEach; @@ -33,6 +34,16 @@ class TestGlueTablePropertiesMetadata { metadata = new GlueTablePropertiesMetadata(); } + @Test + void testTableFormatIsOptional() { + assertFalse(metadata.isRequiredProperty(TABLE_FORMAT)); + } + + @Test + void testTableFormatIsNotHidden() { + assertFalse(metadata.isHiddenProperty(TABLE_FORMAT)); + } + @Test void testMetadataLocationIsOptional() { assertFalse(metadata.isRequiredProperty(METADATA_LOCATION));
