This is an automated email from the ASF dual-hosted git repository. diqiu50 pushed a commit to branch glue-pr03 in repository https://gitbox.apache.org/repos/asf/gravitino.git
commit 1fcc4ccab0cb52b475859f0a6f667a39276df7f1 Author: diqiu50 <[email protected]> AuthorDate: Mon Apr 13 11:47:57 2026 +0800 refactor(catalog-glue): Unify table format naming, rename TABLE_TYPE_FILTER to TABLE_FORMAT_FILTER --- .../catalog/glue/GlueCatalogPropertiesMetadata.java | 12 ++++++------ .../org/apache/gravitino/catalog/glue/GlueConstants.java | 10 +++++----- .../catalog/glue/TestGlueCatalogPropertiesMetadata.java | 12 ++++++------ 3 files changed, 17 insertions(+), 17 deletions(-) diff --git a/catalogs/catalog-glue/src/main/java/org/apache/gravitino/catalog/glue/GlueCatalogPropertiesMetadata.java b/catalogs/catalog-glue/src/main/java/org/apache/gravitino/catalog/glue/GlueCatalogPropertiesMetadata.java index 43d8696ada..e3215cf7d6 100644 --- a/catalogs/catalog-glue/src/main/java/org/apache/gravitino/catalog/glue/GlueCatalogPropertiesMetadata.java +++ b/catalogs/catalog-glue/src/main/java/org/apache/gravitino/catalog/glue/GlueCatalogPropertiesMetadata.java @@ -24,9 +24,9 @@ import static org.apache.gravitino.catalog.glue.GlueConstants.AWS_GLUE_ENDPOINT; import static org.apache.gravitino.catalog.glue.GlueConstants.AWS_REGION; import static org.apache.gravitino.catalog.glue.GlueConstants.AWS_SECRET_ACCESS_KEY; import static org.apache.gravitino.catalog.glue.GlueConstants.DEFAULT_TABLE_FORMAT; +import static org.apache.gravitino.catalog.glue.GlueConstants.DEFAULT_TABLE_FORMAT_FILTER; import static org.apache.gravitino.catalog.glue.GlueConstants.DEFAULT_TABLE_FORMAT_VALUE; -import static org.apache.gravitino.catalog.glue.GlueConstants.DEFAULT_TABLE_TYPE_FILTER; -import static org.apache.gravitino.catalog.glue.GlueConstants.TABLE_TYPE_FILTER; +import static org.apache.gravitino.catalog.glue.GlueConstants.TABLE_FORMAT_FILTER; import static org.apache.gravitino.connector.PropertyEntry.stringOptionalPropertyEntry; import static org.apache.gravitino.connector.PropertyEntry.stringRequiredPropertyEntry; @@ -92,12 +92,12 @@ public class GlueCatalogPropertiesMetadata extends BaseCatalogPropertiesMetadata DEFAULT_TABLE_FORMAT_VALUE, false /* hidden */)) .put( - TABLE_TYPE_FILTER, + TABLE_FORMAT_FILTER, stringOptionalPropertyEntry( - TABLE_TYPE_FILTER, - "Comma-separated table types exposed by listTables() and loadTable().", + TABLE_FORMAT_FILTER, + "Comma-separated table formats exposed by listTables() and loadTable().", false /* immutable */, - DEFAULT_TABLE_TYPE_FILTER, + DEFAULT_TABLE_FORMAT_FILTER, false /* hidden */)) .build(); diff --git a/catalogs/catalog-glue/src/main/java/org/apache/gravitino/catalog/glue/GlueConstants.java b/catalogs/catalog-glue/src/main/java/org/apache/gravitino/catalog/glue/GlueConstants.java index 80ed086716..f33f6c3c21 100644 --- a/catalogs/catalog-glue/src/main/java/org/apache/gravitino/catalog/glue/GlueConstants.java +++ b/catalogs/catalog-glue/src/main/java/org/apache/gravitino/catalog/glue/GlueConstants.java @@ -56,13 +56,13 @@ public final class GlueConstants { public static final String DEFAULT_TABLE_FORMAT_VALUE = "hive"; /** - * Comma-separated list of table types exposed by {@code listTables()} and {@code loadTable()} + * Comma-separated list of table formats exposed by {@code listTables()} and {@code loadTable()} * (optional). Defaults to {@code all}. */ - public static final String TABLE_TYPE_FILTER = "table-type-filter"; + public static final String TABLE_FORMAT_FILTER = "table-format-filter"; - /** Default value for {@link #TABLE_TYPE_FILTER}: expose all table types. */ - public static final String DEFAULT_TABLE_TYPE_FILTER = "all"; + /** Default value for {@link #TABLE_FORMAT_FILTER}: expose all table formats. */ + public static final String DEFAULT_TABLE_FORMAT_FILTER = "all"; // ------------------------------------------------------------------------- // Glue Table.parameters() keys (passthrough properties) @@ -71,7 +71,7 @@ public final class GlueConstants { /** * Glue table format type parameter key stored in {@code Table.parameters()}. Common values: * {@code ICEBERG}, {@code HIVE}, {@code DELTA}, {@code PARQUET} (uppercase, as stored by Glue). - * Note: these differ from the Gravitino-side filter values in {@link #TABLE_TYPE_FILTER}, which + * Note: these differ from the Gravitino-side filter values in {@link #TABLE_FORMAT_FILTER}, which * use lowercase (e.g. {@code iceberg}, {@code hive}). */ public static final String TABLE_FORMAT_TYPE = "table_format_type"; diff --git a/catalogs/catalog-glue/src/test/java/org/apache/gravitino/catalog/glue/TestGlueCatalogPropertiesMetadata.java b/catalogs/catalog-glue/src/test/java/org/apache/gravitino/catalog/glue/TestGlueCatalogPropertiesMetadata.java index 8d85653326..9a4a8c8201 100644 --- a/catalogs/catalog-glue/src/test/java/org/apache/gravitino/catalog/glue/TestGlueCatalogPropertiesMetadata.java +++ b/catalogs/catalog-glue/src/test/java/org/apache/gravitino/catalog/glue/TestGlueCatalogPropertiesMetadata.java @@ -24,9 +24,9 @@ import static org.apache.gravitino.catalog.glue.GlueConstants.AWS_GLUE_ENDPOINT; import static org.apache.gravitino.catalog.glue.GlueConstants.AWS_REGION; import static org.apache.gravitino.catalog.glue.GlueConstants.AWS_SECRET_ACCESS_KEY; import static org.apache.gravitino.catalog.glue.GlueConstants.DEFAULT_TABLE_FORMAT; +import static org.apache.gravitino.catalog.glue.GlueConstants.DEFAULT_TABLE_FORMAT_FILTER; import static org.apache.gravitino.catalog.glue.GlueConstants.DEFAULT_TABLE_FORMAT_VALUE; -import static org.apache.gravitino.catalog.glue.GlueConstants.DEFAULT_TABLE_TYPE_FILTER; -import static org.apache.gravitino.catalog.glue.GlueConstants.TABLE_TYPE_FILTER; +import static org.apache.gravitino.catalog.glue.GlueConstants.TABLE_FORMAT_FILTER; import static org.junit.jupiter.api.Assertions.assertEquals; import static org.junit.jupiter.api.Assertions.assertFalse; import static org.junit.jupiter.api.Assertions.assertTrue; @@ -90,10 +90,10 @@ class TestGlueCatalogPropertiesMetadata { } @Test - void testTableTypeFilterDefaultValue() { + void testTableFormatFilterDefaultValue() { assertEquals( - DEFAULT_TABLE_TYPE_FILTER, - metadata.getDefaultValue(TABLE_TYPE_FILTER), - "Default table type filter should be 'all'"); + DEFAULT_TABLE_FORMAT_FILTER, + metadata.getDefaultValue(TABLE_FORMAT_FILTER), + "Default table format filter should be 'all'"); } }
