FrankChen021 commented on code in PR #20673:
URL: https://github.com/apache/druid/pull/20673#discussion_r4348557106


##########
licenses.yaml:
##########
@@ -4326,25 +4326,26 @@ version: 2.2.0
 libraries:
   - com.google.http-client: google-http-client
   - com.google.http-client: google-http-client-jackson2
+  - com.google.http-client: google-http-client-apache-v2
+  - com.google.http-client: google-http-client-gson
 
 ---
 
-name: Google HTTP Client Library For Java
+name: Google API Common
 license_category: binary
 module: java-core
-license_name: Apache License version 2.0
-version: 1.45.2
+license_name: BSD-3-Clause License
+version: 2.70.0
 libraries:
-  - com.google.http-client: google-http-client-apache-v2
-  - com.google.http-client: google-http-client-gson
+  - com.google.api: api-common

Review Comment:
   [P2] Register api-common's annotation dependency for java-core
   
   **Finding:** api-common:2.70.0 is newly brought into java-core by the BOM 
change and declares javax.annotation:javax.annotation-api:1.3.2. The registry 
currently records that artifact only under extensions/druid-avro-extensions, so 
the new java-core/lib dependency path is missing from the module-specific 
license metadata.
   
   **Suggestion:** Add a java-core license entry for 
javax.annotation:javax.annotation-api at version 1.3.2, reusing the existing 
CDDL license file.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to