FrankChen021 commented on code in PR #20673:
URL: https://github.com/apache/druid/pull/20673#discussion_r4348262326
##########
pom.xml:
##########
@@ -1623,6 +1579,24 @@
<artifactId>re2j</artifactId>
<version>1.8</version>
</dependency>
+ <dependency>
+ <groupId>org.graalvm.sdk</groupId>
+ <artifactId>nativeimage</artifactId>
+ <version>${graaljs.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.graalvm.sdk</groupId>
+ <artifactId>word</artifactId>
+ <version>${graaljs.version}</version>
+ </dependency>
Review Comment:
Confirmed after rechecking the current head and all 7 of 7 changed files:
Druid does not reference `nativeimage` or `word` directly, but the runtime
`js-scriptengine` dependency in `services` and `indexing-service` pulls them
transitively through `polyglot`. Pinning both to `${graaljs.version}` keeps the
GraalVM stack aligned when `libraries-bom` is imported. The added comment
accurately documents the reason; no further action is needed.
<!-- mergelens:review -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
