amaechler commented on code in PR #20673:
URL: https://github.com/apache/druid/pull/20673#discussion_r4343989929
##########
pom.xml:
##########
@@ -1623,6 +1579,24 @@
<artifactId>re2j</artifactId>
<version>1.8</version>
</dependency>
+ <dependency>
+ <groupId>org.graalvm.sdk</groupId>
+ <artifactId>nativeimage</artifactId>
+ <version>${graaljs.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.graalvm.sdk</groupId>
+ <artifactId>word</artifactId>
+ <version>${graaljs.version}</version>
+ </dependency>
Review Comment:
Druid doesn't use them directly. They come in through GraalJS
(`js-scriptengine > polyglot > nativeimage > word`) which ships in `lib/` for
the JavaScript script engine.
The problem is that `libraries-bom` also manages these two (through
`com.google.cloud:native-image-shared-config`) and sets them to 25.0.0. Without
these entries we'd ship `nativeimage` and `word` at 25.0.0 next to `polyglot`,
`collections` and `truffle` at 25.3.4.1. Pinning them to `${graaljs.version}`
keeps all the GraalVM jars on the same version.
You can check it on the PR branch. With the pins, everything is on 25.3.4.1:
```
./mvnw -q dependency:tree -pl services -Dincludes=org.graalvm.sdk
-DoutputFile=/dev/stdout
```
Remove the two entries and run it again, and `nativeimage` and `word` drop
to 25.0.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
