HappenLee commented on code in PR #17300:
URL: https://github.com/apache/doris/pull/17300#discussion_r1125897141
##########
be/src/runtime/fold_constant_executor.cpp:
##########
@@ -180,24 +179,14 @@ string FoldConstantExecutor::_get_result(void* src,
size_t size, const TypeDescr
case TYPE_STRING:
case TYPE_HLL:
case TYPE_OBJECT: {
- if constexpr (is_vec) {
- return std::string((char*)src, size);
- }
- return (reinterpret_cast<StringRef*>(src))->to_string();
+ return std::string((char*)src, size);
}
case TYPE_DATE:
case TYPE_DATETIME: {
- if constexpr (is_vec) {
Review Comment:
better remove `is_vec` ？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
