HappenLee commented on code in PR #17300:
URL: https://github.com/apache/doris/pull/17300#discussion_r1125893042
##########
be/src/vec/functions/cast_type_to_either.h:
##########
@@ -27,7 +27,7 @@ namespace doris::vectorized {
class IDataType;
template <typename... Ts, typename F>
-static bool cast_type_to_either(const IDataType* type, F&& f) {
+inline bool cast_type_to_either(const IDataType* type, F&& f) {
Review Comment:
For template functions, I'd say that using static, inline or no keyword
produce the same result; in fact, in all cases the function will be inlined and
no multiple definition error will be raised.
https://stackoverflow.com/questions/29495678/why-use-static-function-template
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
